Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/37886/7/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java: Line 62: String message = t.getMessage() != null ? t.getMessage() : t.getClass().getName(); Line 63: System.err.println(message); Line 64: logger.error(message); Line 65: logger.debug(message, t); Line 66: System.exit(1); single exit please... :) declare a variable ret, and single exit at end of program. Line 67: } Line 68: } Line 69: Line 70: private static void loadExtensions(ModuleService moduleService, Map<String, Object> argMap) { https://gerrit.ovirt.org/#/c/37886/7/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerServiceImpl.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerServiceImpl.java: Line 32: logrecord(); Line 33: } Line 34: } Line 35: ); Line 36: } so you do not need default constructor now, night? Line 37: Line 38: @Override Line 39: public String getName() { Line 40: return "logger"; -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
