Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command for scheduling volume snapshot ......................................................................
Patch Set 11: (4 comments) https://gerrit.ovirt.org/#/c/36980/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java: Line 45: > you can use getGlusterVolume() from base class as the volume id has been se done Line 101: . > tZone param to be used here done. Later I moved to a method so forgot to change Line 102: > format.format(inDate) done Line 103: > Shouldn't conversion be from the timezone to engine timezone, assuming the Yes. we need to parse using the given timezone -- To view, visit https://gerrit.ovirt.org/36980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4326ebb0c146eadceb6ae30cce73ece132749dc5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
