Sahina Bose has posted comments on this change. Change subject: gluster: BLL command for scheduling volume snapshot ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/36980/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java: Line 68: new Class[] { String.class, String.class, String.class, String.class, Boolean.class }, Line 69: new Object[] { upServer.getId().toString(), getGlusterVolumeId().toString(), Line 70: schedule.getSnapshotNamePrefix(), Line 71: schedule.getSnapshotDescription(), force }, Line 72: cronExpression, schedule.getStartDate(), schedule.getEndByDate()); > The Date type is internally maintained as no of millis from epoch as a long How are you setting this Date from the UI. Are you considering the selected timezone when getting this Date instance? Line 73: } Line 74: protected GlusterVolumeSnapshotScheduleDao getGlusterVolumeSnapshotScheduleDao() { Line 75: return DbFacade.getInstance().getGlusterVolumeSnapshotScheduleDao(); Line 76: } -- To view, visit https://gerrit.ovirt.org/36980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4326ebb0c146eadceb6ae30cce73ece132749dc5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
