Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command for scheduling volume snapshot ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/36980/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java: Line 318: calFrom.set(Calendar.HOUR, inTime.getHours()); Line 319: calFrom.set(Calendar.MINUTE, inTime.getMinutes()); Line 320: calFrom.set(Calendar.SECOND, inTime.getSeconds()); Line 321: Line 322: Calendar calTo = new GregorianCalendar(TimeZone.getTimeZone(Config.<String> getValue(ConfigValues.DefaultGeneralTimeZone))); > There are only two timezone details maintained as part of vdc_options namel As discussed we just need an instance of GregorianCalendar without any timezone, so calendar is created for the default engine timezone. Also below while returning time we need to user HOUR_OF_DAY to return 24 hrs format, hour value. Line 323: calTo.setTimeInMillis(calFrom.getTimeInMillis()); Line 324: Line 325: return new Time(calTo.get(Calendar.HOUR), calTo.get(Calendar.MINUTE), calTo.get(Calendar.SECOND)); Line 326: } -- To view, visit https://gerrit.ovirt.org/36980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4326ebb0c146eadceb6ae30cce73ece132749dc5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
