anmolbabu has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshot actions ......................................................................
Patch Set 7: Code-Review+1 One small comment on patch set 6 and also please don't forget to verify if the error dialog is shown in case of error(bcoz you are doing setConfirmWindow(null) in callback and I don't see the error being handled. I am sure the error dialog will be thrown by framework but not sure how setConfirmWindow(null) in call back affects it). -- To view, visit https://gerrit.ovirt.org/38151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5b6162c6c6931cd0366db5ba600566ab8ac7c9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
