anmolbabu has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshot actions ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38151/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 193: model.setTitle(ConstantsManager.getInstance().getMessages().confirmRestoreSnapshot(getEntity().getName())); Line 194: model.setHelpTag(HelpTag.volume_restore_snapshot_confirmation); Line 195: model.setHashName("volume_restore_snapshot_confirmation"); //$NON-NLS-1$ Line 196: if (snapshot.getStatus() == GlusterSnapshotStatus.STARTED) { Line 197: model.setMessage(ConstantsManager.getInstance() can you have a string that is set conditionally and then 1 single model.setmessage thatstring at the bottom any way 1 message is compulsorily there right? Line 198: .getConstants() Line 199: .confirmVolumeSnapshotRestoreWithStopMessage()); Line 200: } else { Line 201: model.setMessage(ConstantsManager.getInstance().getConstants().confirmVolumeSnapshotRestoreMesage()); -- To view, visit https://gerrit.ovirt.org/38151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5b6162c6c6931cd0366db5ba600566ab8ac7c9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
