anmolbabu has posted comments on this change. Change subject: webadmin: UI for gluster volume snapshot actions ......................................................................
Patch Set 4: (7 comments) https://gerrit.ovirt.org/#/c/38151/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeSnapshotListModel.java: Line 267: @Override Line 268: public void executed(FrontendMultipleActionAsyncResult result) { Line 269: ConfirmationModel localModel = (ConfirmationModel) getConfirmWindow(); Line 270: localModel.stopProgress(); Line 271: setConfirmWindow(null); Please make sure this won't close the error dialog in case of a failure Line 272: } Line 273: }, model); Line 274: } Line 275: Line 347: } Line 348: Line 349: ConfirmationModel model = (ConfirmationModel) getConfirmWindow(); Line 350: if (model.getProgress() != null) { Line 351: return; when would this happen and if it happens then the window will simply have progress indication and actually nothing will happen Line 352: } Line 353: Line 354: model.startProgress(null); Line 355: Line 357: @Override Line 358: public void executed(FrontendActionAsyncResult result) { Line 359: ConfirmationModel localModel = (ConfirmationModel) getConfirmWindow(); Line 360: localModel.stopProgress(); Line 361: setConfirmWindow(null); Please make sure this won't close the error dialog in case of a failure Line 362: } Line 363: }); Line 364: } https://gerrit.ovirt.org/#/c/38151/4/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 2558: + "Changing configuration parameters will lead to deletion of snapshots if they exceed the new limit.\n\n" Line 2559: + "Are you sure you want to continue?") Line 2560: String youAreAboutChangeSnapshotConfigurationMsg(); Line 2561: Line 2562: @DefaultStringValue("Volume will be restore to the state of selected snapshot.\nDo you want to continue?") Volume will be restored to the state of selected snapshot.\nDo you want to c ontinue? Line 2563: String confirmVolumeSnapshotRestoreMesage(); Line 2564: Line 2565: @DefaultStringValue("The volume will be brought down and restored to the state of the selected snapshot.\nDo you want to continue?") Line 2566: String confirmVolumeSnapshotRestoreWithStopMessage(); Line 2564: Line 2565: @DefaultStringValue("The volume will be brought down and restored to the state of the selected snapshot.\nDo you want to continue?") Line 2566: String confirmVolumeSnapshotRestoreWithStopMessage(); Line 2567: Line 2568: @DefaultStringValue("All snapshots would be removed. Do you want to continue?") "All snapshots will be removed. Do you want to continue?" Line 2569: String confirmVolumeSnapshotDeleteAllMessage(); Line 2570: Line 2571: @DefaultStringValue("The selected snapshot will be activated. Do you want to continue?") Line 2572: String confirmVolumeSnapshotActivateMessage(); https://gerrit.ovirt.org/#/c/38151/4/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java: Line 424: Line 425: @DefaultMessage("Value of volume configuration parameter {0} is empty") Line 426: String volumeSnapshotOptionValueEmpty(String option); Line 427: Line 428: @DefaultMessage("Restore Snapshot - {0}") "Restore Snapshot on - {0}" ? Line 429: String confirmRestoreSnapshot(String volumeName); Line 430: Line 431: @DefaultMessage("Remove Snapshot - {0}") Line 432: String confirmRemoveSnapshot(String volumeName); Line 428: @DefaultMessage("Restore Snapshot - {0}") Line 429: String confirmRestoreSnapshot(String volumeName); Line 430: Line 431: @DefaultMessage("Remove Snapshot - {0}") Line 432: String confirmRemoveSnapshot(String volumeName); same for all the below except for the last one Bcoz, I think user user might get confused about if its a snapshot name or volume name. What do you opine? Line 433: Line 434: @DefaultMessage("Remove All Snapshots - {0}") Line 435: String confirmRemoveAllSnapshots(String volumeName); Line 436: -- To view, visit https://gerrit.ovirt.org/38151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5b6162c6c6931cd0366db5ba600566ab8ac7c9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
