Ramesh N has posted comments on this change. Change subject: engine : Entity and DAO changes for Disk provisioning ......................................................................
Patch Set 6: (10 comments) Patch set to follow. https://gerrit.ovirt.org/#/c/36428/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java: > please implement toString() as well Done Line 1: package org.ovirt.engine.core.common.businessentities.gluster; Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.BusinessEntity; Line 4: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 4: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 5: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 6: import org.ovirt.engine.core.compat.Guid; Line 7: Line 8: public class StorageDevice extends IVdcQueryable implements BusinessEntity<Guid> { > I'm not familiar with this feature, haven't seen any description of this en Sorry for missing the description part. I will add it now. This entity represent storage devices attached to the system. So its not created by the user through some action in Ovirt. Line 9: Line 10: private static final long serialVersionUID = 1L; Line 11: Line 12: private Guid id; Line 6: import org.ovirt.engine.core.compat.Guid; Line 7: Line 8: public class StorageDevice extends IVdcQueryable implements BusinessEntity<Guid> { Line 9: Line 10: private static final long serialVersionUID = 1L; > not generated ? Done Line 11: Line 12: private Guid id; Line 13: private String name; Line 14: private String devUuid; Line 14: private String devUuid; Line 15: private String fsUuid; Line 16: private Guid vdsId; Line 17: private String description; Line 18: private String devType; > can devType be defined as enum or is it a free text ? It can be defined as enum, but defined list could limit further new bus type. Keeping it as free text could help in that. Line 19: private String devPath; Line 20: private String fsType; Line 21: private String mountPoint; Line 22: private Long size; Line 18: private String devType; Line 19: private String devPath; Line 20: private String fsType; Line 21: private String mountPoint; Line 22: private Long size; > can it be primitive ? It can be primitive. Line 23: private Boolean canCreateBrick; Line 24: Line 25: public StorageDevice() { Line 26: super(); Line 19: private String devPath; Line 20: private String fsType; Line 21: private String mountPoint; Line 22: private Long size; Line 23: private Boolean canCreateBrick; > can it be primitive ? It can be primitive. Line 24: Line 25: public StorageDevice() { Line 26: super(); Line 27: } Line 26: ) > this is redundant removed Line 25: public StorageDevice() { Line 26: super(); Line 27: } Line 28: Line 29: public static long getSerialversionuid() { > why is it required ? removed. Line 30: return serialVersionUID; Line 31: } Line 32: Line 33: public String getName() { Line 108: } Line 109: Line 110: @Override Line 111: public Guid getId() { Line 112: return this.id; > this. prefix is not required within getters Done Line 113: } Line 114: Line 115: @Override Line 116: public void setId(Guid id) { https://gerrit.ovirt.org/#/c/36428/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java: Line 8: Line 9: /** Line 10: * Interface for DB operations on Storage Device Entities Line 11: */ Line 12: public interface StorageDeviceDao extends DAO { > please extend the standard GenericDao which already defines all those metho Done Line 13: Line 14: public StorageDevice getById(Guid id); Line 15: Line 16: public void save(StorageDevice storageDevice); -- To view, visit https://gerrit.ovirt.org/36428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
