Ramesh N has posted comments on this change.

Change subject: engine : Entity and DAO changes for Disk provisioning
......................................................................


Patch Set 8:

(1 comment)

renumbered the db script. Patch set to follow.

https://gerrit.ovirt.org/#/c/36428/8/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java:

Line 12:  * Interface for DB operations on Storage Device Entities
Line 13:  */
Line 14: public interface StorageDeviceDao extends 
ModificationDao<StorageDevice, Guid>, MassOperationsDao<StorageDevice, Guid>, 
Serializable {
Line 15: 
Line 16:     public StorageDevice get(Guid id);
> all methods within interface are public by default, hence this access modif
Done
Line 17: 
Line 18:     public List<StorageDevice> getStorageDevicesInHost(Guid hostId);
Line 19: 
Line 20:     public void updateIsFreeFlag(Guid deviceId, boolean isFree);


-- 
To view, visit https://gerrit.ovirt.org/36428
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to