Ramesh N has posted comments on this change. Change subject: engine : Entity and DAO changes for Disk provisioning ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/36428/5/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/StoageDeviceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/StoageDeviceDaoTest.java: Line 46: @Test Line 47: public void testGetById(){ Line 48: StorageDevice storageDevice = dao.getById(EXISTING_STORAGE_DEVICE_ID_1); Line 49: assertNotNull("Failed to retrive storage device", storageDevice); Line 50: assertEquals("Failed to retrive corrective storage device", storageDevice.getId(), EXISTING_STORAGE_DEVICE_ID_1); > expected as the second arg, actual third arg Done Line 51: Line 52: storageDevice = dao.getById(NON_EXISTING_STORAGE_DEVICE_ID); Line 53: assertNull(storageDevice); Line 54: } -- To view, visit https://gerrit.ovirt.org/36428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
