Arik Hadas has posted comments on this change. Change subject: core: return locks state in vm search ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38247/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 467: } Line 468: } Line 469: Line 470: public static void updateVmLock(final VM vm) { Line 471: vm.setLockInfo(getLockManager().getLockInfo(String.format("%s%s", vm.getId(), LockingGroup.VM.name()))); > it would be nicer if you just pass the key string (vm id) and locking group agree, will do when we'll generalize it to additional entities Line 472: } Line 473: Line 474: protected static LockManager getLockManager() { Line 475: return LockManagerFactory.getLockManager(); -- To view, visit https://gerrit.ovirt.org/38247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693a223b47dadb13f38fefadadc0ff778fe5ab9b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
