Moti Asayag has posted comments on this change. Change subject: core: return locks state in vm search ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/38247/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java: Line 471: LockingGroup.VM you can use here LockingGroup.VM.name() and not worry of some unexpected LockingGroup.toString() future implementation https://gerrit.ovirt.org/#/c/38247/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 50: private boolean nextRunConfigurationExists; Line 51: Line 52: private String hibernationVolHandle; Line 53: Line 54: private LockInfo lockInfo; is there a plan to report the lockInfo for addition business entities ? Line 55: Line 56: public String getUserDefinedProperties() { Line 57: return vmStatic.getUserDefinedProperties(); Line 58: } -- To view, visit https://gerrit.ovirt.org/38247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I693a223b47dadb13f38fefadadc0ff778fe5ab9b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
