Arik Hadas has posted comments on this change.

Change subject: core: return locks state in vm search
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38247/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java:

Line 50:     private boolean nextRunConfigurationExists;
Line 51: 
Line 52:     private String hibernationVolHandle;
Line 53: 
Line 54:     private LockInfo lockInfo;
> is there a plan to report the lockInfo for addition business entities ?
yes, but we decided to start with VM since without it we create "regressions" 
in hibernate flow (already merged) and import vm flow (waiting for this patch) 
in 3.6. later on we'll generalize it to all relevant business entities (there 
are other things to think about - like, whether we want it in the search or in 
the base-dao. I just don't want additional thing that blocks virt-v2v 
integration)
Line 55: 
Line 56:     public String getUserDefinedProperties() {
Line 57:         return vmStatic.getUserDefinedProperties();
Line 58:     }


-- 
To view, visit https://gerrit.ovirt.org/38247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I693a223b47dadb13f38fefadadc0ff778fe5ab9b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to