Yevgeny Zaspitsky has posted comments on this change. Change subject: engine: Add gluster role to network cluster ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/37471/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java: Line 166: true, Line 167: true, Line 168: true, Line 169: true, Line 170: false); Don't you like management network would be used as a gluster network by default? Line 171: } Line 172: Line 173: @Override Line 174: public List<PermissionSubject> getPermissionCheckSubjects() { https://gerrit.ovirt.org/#/c/37471/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 143: true, Line 144: true, Line 145: true, Line 146: true, Line 147: false); Don't you like management network would be used as a gluster network by default? Line 148: return networkCluster; Line 149: } Line 150: Line 151: @Override -- To view, visit https://gerrit.ovirt.org/37471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idac78d2c57f4d09aeb368b135f45dcf3237415e7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
