Moti Asayag has posted comments on this change. Change subject: engine: Add gluster role to network cluster ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/37471/6/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 1180: END IF; Line 1181: Line 1182: END; $procedure$ Line 1183: LANGUAGE plpgsql; Line 1184: relooking at this stored procedure and the other which shares the same principal - i don't see why can't it be simplified to a single query: CREATE OR REPLACE FUNCTION public.set_network_exclusively_as_migration2(v_cluster_id uuid, v_network_id uuid) RETURNS void LANGUAGE plpgsql AS $function$ BEGIN UPDATE network_cluster SET migration = (network_id = v_network_id) WHERE cluster_id = v_cluster_id; END; $function$ Eli, do you see any issue with the suggested update statement? Lior, I suggest changing the other queries respectively if Eli is fine with it. Line 1185: Line 1186: Create or replace FUNCTION set_network_exclusively_as_management(v_cluster_id UUID, v_network_id UUID) Line 1187: RETURNS VOID Line 1188: AS $procedure$ -- To view, visit https://gerrit.ovirt.org/37471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idac78d2c57f4d09aeb368b135f45dcf3237415e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
