Sahina Bose has posted comments on this change. Change subject: engine: Add gluster role to network cluster ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/37471/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java: Line 100: getNetworkClusterDAO().setNetworkExclusivelyAsMigration(getVdsGroupId(), Line 101: getNetworkCluster().isMigration() ? getPersistedNetwork().getId() : managementNetwork.getId()); Line 102: } Line 103: Line 104: if (getNetworkCluster().isGluster() != getOldNetworkCluster().isGluster()) { > If we want to support split dns setup as u mentioned in the previous commen Done Line 105: getNetworkClusterDAO().setNetworkExclusivelyAsGluster(getVdsGroupId(), Line 106: getNetworkCluster().isGluster() ? getPersistedNetwork().getId() : getManagementNetwork().getId()); Line 107: } Line 108: -- To view, visit https://gerrit.ovirt.org/37471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idac78d2c57f4d09aeb368b135f45dcf3237415e7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Karnan t c <kchid...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
