Alon Bar-Lev has posted comments on this change. Change subject: aaa: extensions test tool: logger ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37886/1/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java: Line 1: package org.ovirt.engine.exttool.core; Line 2: Line 3: public interface ModuleService { Line 4: Line 5: public void runModule(ExtensionsToolArguments args) throws Exception; > hmm, shouldn't be parsing args global? not per service? well, not sure what "parsing" is, but every service knows his own parameters... so infra must consult the module. the simplest: xxx --help <get a list of modules> xxx module --help <get a list of options for that module> notice the core does not care what modules are in there, all is dynamic acquired from service. Line 6: -- To view, visit http://gerrit.ovirt.org/37886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
