Ondřej Macháček has posted comments on this change. Change subject: aaa: extensions test tool: logger ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/37886/1/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolArguments.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolArguments.java: Line 6: import java.util.Map; Line 7: import java.util.Properties; Line 8: import java.util.Set; Line 9: Line 10: import com.sun.org.apache.xpath.internal.operations.Mod; > what is that? Hmm, an accident, will remove. Line 11: import org.ovirt.engine.core.uutils.cli.ArgumentBuilder; Line 12: import org.ovirt.engine.core.uutils.cli.ExtendedCliParser; Line 13: Line 14: public class ExtensionsToolArguments { http://gerrit.ovirt.org/#/c/37886/1/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerService.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerService.java: Line 2: Line 3: Line 4: import org.ovirt.engine.exttool.core.ModuleService; Line 5: Line 6: public interface LoggerService extends ModuleService { > so why do you need this interface? That's how jdk ServiceLoader works. I need to specify interface name, and I can't two or more implementations, for one interface name, I will have to specify such interfaces for every module. But I will access to them via ModulerService. this is only because of the serviceLoader. Line 7: http://gerrit.ovirt.org/#/c/37886/1/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/logger/services/help.properties File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/logger/services/help.properties: Line 8: \n\t\t\t\tLogger::FLUSH\ Line 9: \n\t\t\t\tLogger::CLOSE\ Line 10: \n\t\t\t--logger-name="org.ovirt.engine"\ Line 11: \n\t\t\t--level=INFO\ Line 12: \n\t\t\t--message="test" > hmmm... won't it be simpler to just put text file as resource? yes, will do http://gerrit.ovirt.org/#/c/37886/1/packaging/bin/ovirt-engine-extensions-tool.sh File packaging/bin/ovirt-engine-extensions-tool.sh: Line 25: -jar "${JBOSS_HOME}/jboss-modules.jar" \ Line 26: -dependencies org.ovirt.engine.core.extension-tool \ Line 27: -cp "${CLASSPATH}:${ENGINE_USR}/conf/extensions-tool/commons-logging.properties" \ Line 28: -class org.ovirt.engine.exttool.core.ExtensionsToolExecutor \ Line 29: "$@" > please copy as much as you can packaging/bin/engine-manage-domains.sh, for ok -- To view, visit http://gerrit.ovirt.org/37886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
