Ondřej Macháček has posted comments on this change. Change subject: aaa: extensions test tool: logger ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37886/1/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerService.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/logger/services/LoggerService.java: Line 2: Line 3: Line 4: import org.ovirt.engine.exttool.core.ModuleService; Line 5: Line 6: public interface LoggerService extends ModuleService { > yes, your interface is ModuleService, the core should not care what we test Then I can't use jdk ServiceLoader, but find different way, which suite. ServiceLoader can't have specified multiple implementaion for one interface. Line 7: -- To view, visit http://gerrit.ovirt.org/37886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
