Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: asking about retriyng VG creation with force option ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/37845/6/src/plugins/ovirt-hosted-engine-setup/storage/blockd.py File src/plugins/ovirt-hosted-engine-setup/storage/blockd.py: Line 365 Line 366 Line 367 Line 368 Line 369 > Mb should be MB or MiB - for another patch. No, it's just in the logs. Ok to fix it in another patch. Line 424: self.environment[ Line 425: ohostedcons.StorageEnv.VG_UUID Line 426: ] = device['vgUUID'] Line 427: Line 428: if device['status'] == 'used' and device['vgUUID'] == '': > Why do you check for empty vgUUID? On additional host (on 3.6 additional hosts should be added just via web UI but now they are still here) the user is selecting the LUN with the storage domain that he used for the first host. The user can also select an existing storage domain for upgrades. So, if we have a valid storage domain we also have a valid VG and it's a valid use case. We just want to prevent any further error on device marked as used but without a VG (maybe cause there is a partition table or something else) Line 429: self._customize_forcecreatevg() Line 430: if not self.environment[ Line 431: ohostedcons.StorageEnv.FORCE_CREATEVG Line 432: ]: -- To view, visit http://gerrit.ovirt.org/37845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
