Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: asking about retriyng VG creation with force option ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/37845/1/src/plugins/ovirt-hosted-engine-setup/storage/blockd.py File src/plugins/ovirt-hosted-engine-setup/storage/blockd.py: Line 567: ohostedcons.StorageEnv.PROMPT_RETRY_CREATEVG Line 568: ] is None: Line 569: self.environment[ Line 570: ohostedcons.StorageEnv.PROMPT_RETRY_CREATEVG Line 571: ] = self.dialog.queryString( > Why do you need to keep the result of the dialog in the environment? This s It's just to have it externally overridable for testing or machine automation purposes. Line 572: name='OVEHOSTED_RETRY_CREATEVG', Line 573: note=_( Line 574: 'Error creating Volume Group: {message}\n' Line 575: 'The selected device was probably dirty.\n\n' Line 593: [ Line 594: self.environment[ohostedcons.StorageEnv.LUN_ID], Line 595: ], Line 596: force=True, Line 597: ) > This repeats the same code above - should move to helper function. Done Line 598: self.logger.debug(dom) Line 599: if dom['status']['code'] != 0: Line 600: raise RuntimeError(dom['status']['message']) Line 601: else: Line 598: self.logger.debug(dom) Line 599: if dom['status']['code'] != 0: Line 600: raise RuntimeError(dom['status']['message']) Line 601: else: Line 602: raise RuntimeError(dom['status']['message']) > The code is very hard to follow. This make it hard to review and hard to ma Done Line 603: self.environment[ Line 604: ohostedcons.StorageEnv.VG_UUID Line 605: ] = dom['uuid'] Line 606: -- To view, visit http://gerrit.ovirt.org/37845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
