Nir Soffer has posted comments on this change. Change subject: packaging: setup: asking about retriyng VG creation with force option ......................................................................
Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/37845/6/src/plugins/ovirt-hosted-engine-setup/storage/blockd.py File src/plugins/ovirt-hosted-engine-setup/storage/blockd.py: Line 365 Line 366 Line 367 Line 368 Line 369 Mb should be MB or MiB - for another patch. Is this visible to the user? if yes, you should use GB or GiB. Line 262: ohostedcons.StorageEnv.FORCE_CREATEVG Line 263: ] = self.dialog.queryString( Line 264: name='OVEHOSTED_FORCE_CREATEVG', Line 265: note=_( Line 266: 'The selected device is probably dirty.\n' I commented in the previous patch about "dirty". Please check again these comments. Line 267: 'Would you like to force VG creation ' Line 268: '(WARNING: it can destroy any existing data on ' Line 269: 'the specified device)\n' Line 270: "(@VALUES@)[@DEFAULT@]? " Line 424: self.environment[ Line 425: ohostedcons.StorageEnv.VG_UUID Line 426: ] = device['vgUUID'] Line 427: Line 428: if device['status'] == 'used' and device['vgUUID'] == '': Why do you check for empty vgUUID? Line 429: self._customize_forcecreatevg() Line 430: if not self.environment[ Line 431: ohostedcons.StorageEnv.FORCE_CREATEVG Line 432: ]: -- To view, visit http://gerrit.ovirt.org/37845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I496c34e6b9f0d84443a8d5bc68d77916be6cb504 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
