Lior Vernia has posted comments on this change. Change subject: webadmin: ClusterNetworkManageModel - add management column ......................................................................
Patch Set 17: (4 comments) http://gerrit.ovirt.org/#/c/36403/17/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java: Line 21: Line 22: private final SearchableListModel<?> sourceListModel; Line 23: private final UICommand okCommand; Line 24: private final UICommand cancelCommand; Line 25: private ClusterNetworkModel managementNetwork = null; Why is this needed? Isn't null the default value for any non-primitive member?... Line 26: private boolean needsAnyChange; Line 27: Line 28: public ClusterNetworkManageModel(SearchableListModel<?> sourceListModel) { Line 29: this.sourceListModel = sourceListModel; Line 106: } Line 107: model.setMigrationNetwork(value); Line 108: } Line 109: Line 110: private ClusterNetworkModel getManagementNetwork() { There are now mixed references to the member in this class, some use managementNetwork directly and some used this getter - please make them uniform (either drop the getter or have them all use it)... Line 111: return managementNetwork; Line 112: } Line 113: Line 114: public void setManagementNetwork(ClusterNetworkModel model, boolean value) { http://gerrit.ovirt.org/#/c/36403/17/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java: Line 358: } Line 359: Line 360: @Override Line 361: protected boolean canEdit(ClusterNetworkModel clusterNetworkModel) { Line 362: return clusterNetworkModel.isAttached() && !clusterNetworkModel.isExternal()&& Formatting? Line 363: !(multiCluster && clusterNetworkModel.getOriginalNetworkCluster().isManagement()); Line 364: } Line 365: } Line 366: Line 359: Line 360: @Override Line 361: protected boolean canEdit(ClusterNetworkModel clusterNetworkModel) { Line 362: return clusterNetworkModel.isAttached() && !clusterNetworkModel.isExternal()&& Line 363: !(multiCluster && clusterNetworkModel.getOriginalNetworkCluster().isManagement()); I think getOriginalNetworkCluster() may return null (if network wasn't originally attached). Line 364: } Line 365: } Line 366: Line 367: private final class ManagementNetworkIndicatorFieldUpdater implements FieldUpdater<ClusterNetworkModel, Boolean> { -- To view, visit http://gerrit.ovirt.org/36403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3153d4aec549b847ef209ea28b36d0329e06a7a9 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
