Yevgeny Zaspitsky has posted comments on this change.

Change subject: webadmin: ClusterNetworkManageModel - add management column
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/36403/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java:

Line 108:     }
Line 109: 
Line 110:     private ClusterNetworkModel getManagementNetwork() {
Line 111:         if (!isMultiCluster()) {
Line 112:             for (ClusterNetworkModel clusterNetworkManageModel : 
getItems()) {
> Why not find the management network when first populating the model, and th
Done
Line 113:                 if (clusterNetworkManageModel.isManagement()) {
Line 114:                     return clusterNetworkManageModel;
Line 115:                 }
Line 116:             }


-- 
To view, visit http://gerrit.ovirt.org/36403
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3153d4aec549b847ef209ea28b36d0329e06a7a9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to