Lior Vernia has posted comments on this change. Change subject: webadmin: ClusterNetworkManageModel - add management column ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/36403/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java: Line 356: } Line 357: Line 358: @Override Line 359: protected boolean canEdit(ClusterNetworkModel clusterNetworkModel) { // TODO Line 360: return clusterNetworkModel.isAttached() && !clusterNetworkModel.isExternal(); > The scenario you described is correct, but I don't agree with the conclusio Oops, sorry, of course there could be more than one cluster/network management combination - so likely the first idea is better (or anything else you come up with...). Line 361: } Line 362: } Line 363: Line 364: private final class ManagementNetworkIndicatorFieldUpdater implements FieldUpdater<ClusterNetworkModel, Boolean> { -- To view, visit http://gerrit.ovirt.org/36403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3153d4aec549b847ef209ea28b36d0329e06a7a9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
