Martin Mucha has posted comments on this change. Change subject: webadmin: fix closing dialog and missing titles ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36898/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/NewSharedMacPoolModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/NewSharedMacPoolModel.java: Line 18: public ClosingWithSetConfirmWindow(Model sourceModel) { Line 19: super(sourceModel); Line 20: } Line 21: Line 22: protected void cancel() { > Missing @Override annotation? Done Line 23: sourceModel.setConfirmWindow(null); Line 24: } Line 25: } Line 26: -- To view, visit http://gerrit.ovirt.org/36898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
