Martin Mucha has posted comments on this change. Change subject: webadmin: fix closing dialog and missing titles ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36898/1//COMMIT_MSG Commit Message: Line 17: Also dialog title wasn't set; changing model on which title is set Line 18: fixed that. Line 19: Line 20: Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Line 21: Bug-Url: https://bugzilla.redhat.com/1180898 > According to this bug, the "New" button in the edit DC dialog isn't working The "New" button is actually working at first. It stops working after it's clicked for the first time, new dialog is opened and closed using 'X". After that "new" button does nothing and webadmin has to be reloaded. None of these bugs generates any exception. I believe the bug does not describe initial state of webadmin, but the state after closing that dialog. After changes in this patch "New" button works everytime clicked. Line 22: Bug-Url: https://bugzilla.redhat.com/1180901 http://gerrit.ovirt.org/#/c/36898/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java: Line 24: private final VdcActionType actionType; Line 25: Line 26: private final EntityModel<String> name = new EntityModel<String>(); Line 27: private final EntityModel<String> description = new EntityModel<String>(); Line 28: private final boolean closeUsingConfirmWindow; > Maybe instead of keeping this boolean member, that doesn't have a lot of si I know that I proposed this, but I have to say that this will suffer from bad design as well, because I can create subclass, which closes with setConfirmWindow method, but then I open dialog using setWindow() and it will not work. So This approach will only solve one unneeded field and replace that with another class (which has another drawback -- bigger JS code). But I think it's cleaner to use subclases for this. Line 29: Line 30: public EntityModel<String> getName() { Line 31: return name; Line 32: } -- To view, visit http://gerrit.ovirt.org/36898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
