Lior Vernia has posted comments on this change. Change subject: webadmin: fix closing dialog and missing titles ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36898/1//COMMIT_MSG Commit Message: Line 17: Also dialog title wasn't set; changing model on which title is set Line 18: fixed that. Line 19: Line 20: Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Line 21: Bug-Url: https://bugzilla.redhat.com/1180898 According to this bug, the "New" button in the edit DC dialog isn't working. I don't see how this patch would fix that - I'm guessing it has to do with some null pointer exception or the model resolution in one of the *Module files. Line 22: Bug-Url: https://bugzilla.redhat.com/1180901 http://gerrit.ovirt.org/#/c/36898/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolModel.java: Line 24: private final VdcActionType actionType; Line 25: Line 26: private final EntityModel<String> name = new EntityModel<String>(); Line 27: private final EntityModel<String> description = new EntityModel<String>(); Line 28: private final boolean closeUsingConfirmWindow; Maybe instead of keeping this boolean member, that doesn't have a lot of significance for this class, create an anonymous subclass of NewSharedMacPoolModel in the edit DC dialog and override its cancel() method to invoke sourceModel.setConfirmWindow(null)? Line 29: Line 30: public EntityModel<String> getName() { Line 31: return name; Line 32: } -- To view, visit http://gerrit.ovirt.org/36898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If38382bbe1a971f8904bbbb4fbd1db7e1855fef4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
