Allon Mureinik has posted comments on this change. Change subject: core,restapi: Glance import - custom disk and template name ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/37105/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java: Line 10: import org.ovirt.engine.core.common.queries.GetImageByIdParameters; Line 11: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 12: import org.ovirt.engine.core.compat.Guid; Line 13: Line 14: import javax.ws.rs.core.Response; Why? Line 15: Line 16: Line 17: public class BackendStorageDomainImageResource Line 18: extends AbstractBackendActionableResource<Image, org.ovirt.engine.core.common.businessentities.RepoImage> Line 56: if (action.isSetDisk()) { Line 57: if (action.getDisk().isSetAlias()) { Line 58: importParameters.setDiskAlias(action.getDisk().getAlias()); Line 59: } Line 60: if (action.getDisk().isSetName()) { if both "name" and "alias" are set, I'd think alias should take effect, no? Line 61: importParameters.setDiskAlias(action.getDisk().getName()); Line 62: } Line 63: } Line 64: -- To view, visit http://gerrit.ovirt.org/37105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
