Juan Hernandez has posted comments on this change. Change subject: core,restapi: Glance import - custom disk and template name ......................................................................
Patch Set 2: (1 comment) Remember that the RSDL metadata needs to be updated with the new optional parameters, otherwise the the CLI won't be able to use them. http://gerrit.ovirt.org/#/c/37105/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java: Line 54: } Line 55: Line 56: if (action.isSetName()) { Line 57: importParameters.setDiskAlias(action.getName()); Line 58: } As what you are setting here is the disk name I think it is better to add a "disk" element to the "ActionParameterGroup" group, and then use the inner "name" element: <action> <disk> <name>imported-disk</name> </disk> </action> This gives you room for adding other potential attributes of the disk. Line 59: Line 60: return doAction(VdcActionType.ImportRepoImage, importParameters, action); Line 61: } Line 62: -- To view, visit http://gerrit.ovirt.org/37105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
