Daniel Erez has posted comments on this change. Change subject: core,restapi: Glance import - custom disk and template name ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/37105/4/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 6590: action.async: xs:boolean Line 6591: action.grace_period.expiry: xs:long Line 6592: action.import_as_template: xs:boolean Line 6593: action.cluster.id|name: xs:string Line 6594: action.disk.alias: xs:string > Can we support both "alias" and "name"? We already support both in many pla yeah, should be fine (though it's deprecated and probably be removed later on..). Done. Line 6595: action.tempalte.name: xs:string Line 6596: urlparams: {} Line 6597: headers: Line 6598: Content-Type: {value: application/xml|json, required: true} Line 6591: action.grace_period.expiry: xs:long Line 6592: action.import_as_template: xs:boolean Line 6593: action.cluster.id|name: xs:string Line 6594: action.disk.alias: xs:string Line 6595: action.tempalte.name: xs:string > The "tempalte" word is misspelled. oops, sorry.. Line 6596: urlparams: {} Line 6597: headers: Line 6598: Content-Type: {value: application/xml|json, required: true} Line 6599: Correlation-Id: {value: 'any string', required: false} http://gerrit.ovirt.org/#/c/37105/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImageResource.java: Line 54: } Line 55: Line 56: if (action.isSetDisk() && action.getDisk().isSetAlias()) { Line 57: importParameters.setDiskAlias(action.getDisk().getAlias()); Line 58: } > Can we support both "alias" and "name"? If both are given then we should pr yeah, should be fine (though it's deprecated and probably be removed later on..). Done. Line 59: Line 60: return doAction(VdcActionType.ImportRepoImage, importParameters, action); Line 61: } Line 62: -- To view, visit http://gerrit.ovirt.org/37105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19da074f7b6ae9d5a0c943c3a7dc6b90a3db03f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
