Alon Bar-Lev has posted comments on this change. Change subject: engine : Add user name to can do action error messages ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/36623/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 136: int index = mUserName.lastIndexOf("@"); Line 137: if (index != -1) { Line 138: mProfileName = mUserName.substring(index + 1); Line 139: mUserName = mUserName.substring(0, index); Line 140: } oh... I did not see that, what do we need this guessing if we have the session with explicit profile name? Line 141: this.mVdsGroupId = auditLog.getVdsGroupId(); Line 142: this.mVdsName = auditLog.getVdsName(); Line 143: this.mVmName = auditLog.getVmName(); Line 144: this.mVmTemplateId = auditLog.getVmTemplateId(); -- To view, visit http://gerrit.ovirt.org/36623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
