Alon Bar-Lev has posted comments on this change.

Change subject: engine : Add user name to can do action error messages
......................................................................


Patch Set 2:

I am so sorry... but... :)

 2015-01-07 22:36:09,094 WARN  
[org.ovirt.engine.core.bll.aaa.LoginAdminUserCommand] (http--0.0.0.0-8080-6) [] 
CanDoAction of action 'LoginAdminUser' failed for user 'alonbl'. Reasons: 
USER_FAILED_TO_AUTHENTICATE_WRONG_USERNAME_OR_PASSWORD

notice that we show no profile name, so wither print alonbl@profile or add 
profile name in messages please.

another example:

2015-01-07 22:37:26,352 ERROR 
[org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] 
(http--0.0.0.0-8080-6) [] Correlation ID: null, Call Stack: null, Custom Event 
ID: -1, Message: User alonbl failed to log in.
2015-01-07 22:37:26,353 WARN  
[org.ovirt.engine.core.bll.aaa.LoginAdminUserCommand] (http--0.0.0.0-8080-6) [] 
CanDoAction of action 'LoginAdminUser' failed for user 'alonbl'. Reasons: 
USER_NOT_AUTHORIZED_TO_PERFORM_ACTION

-- 
To view, visit http://gerrit.ovirt.org/36623
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to