[Engine-patches] Change in ovirt-engine[master]: engine : Add user name to can do action error messages

[rnori]

Ravi Nori has uploaded a new change for review.

Change subject: engine : Add user name to can do action error messages
......................................................................

engine : Add user name to can do action error messages

Add user name to the messages displayed when
canDoAction fails

Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
3 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/36623/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
index 067d225..e54bf3a 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
@@ -772,7 +772,8 @@
                                 && canDoAction()
                                 && internalValidateAndSetQuota();
                 if (!returnValue && 
getReturnValue().getCanDoActionMessages().size() > 0) {
-                    log.warn("CanDoAction of action '{}' failed. Reasons: {}", 
getActionType(),
+                    log.warn("CanDoAction of action '{}' failed for user '{}'. 
Reasons: {}", getActionType(),
+                            getUserName(),
                             
StringUtils.join(getReturnValue().getCanDoActionMessages(), ','));
                 }
             } finally {
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
index 2f9e399..8cacb46 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginAdminUserCommand.java
@@ -12,6 +12,7 @@
 
     @Override
     protected boolean canDoAction() {
+        setUserName(getParameters().getLoginName());
         boolean autheticated = isUserCanBeAuthenticated();
 
         // only admin users can use LoginAdmin command
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
index b9d395b..dc955df 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginBaseCommand.java
@@ -106,6 +106,7 @@
     }
    @Override
     protected boolean canDoAction() {
+        setUserName(getParameters().getLoginName());
         boolean result = isUserCanBeAuthenticated();
         if (! result) {
             logAutheticationFailure();


-- 
To view, visit http://gerrit.ovirt.org/36623
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7776f9f5b93aca96c84fb5a7672e10dded186d05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches