Shireesh Anjal has posted comments on this change. Change subject: core: Performance enhancement for DAO test cases ......................................................................
Patch Set 4: Removed all commit/rollback related code as it is not required. The spring annotation @Transactional, along with the listener TransactionalTestExecutionListener, which were already defined on the class, ensure that all tests run in their own transactions, which are rolled back automatically on completion of the test cases. Thanks Mike for pushing me to use the spring annotations - the code looks far cleaner now. So the only changes in this patch now are: - perform initialization of the data source and insertion of test data (fixtures.xml) only once - Do not destroy the data source on @AfterClass I've tested this, and all the dao tests run successfully in around 26 seconds on my laptop. -- To view, visit http://gerrit.ovirt.org/7336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75afb85ba154808cd3254a1310e0350e6c4279fa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
