Allon Mureinik has posted comments on this change.
Change subject: core: Performance enhancement for DAO test cases
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 122: if(dataSource != null) {
Line 123: Connection con = dataSource.getConnection();
Line 124: if(con != null) {
Line 125: // rollback any changes done to DB during the test
case execution
Line 126: con.rollback();
Rollback should be done after each test case (i.e., with an @After notation,
not an @AfterClass notataion), and I think we should preserve the current
behavior od tearDownTestCase().
I suggest creating a new tearDown() method for performing the rollback.
Line 127: }
Line 128: }
Line 129: }
Line 130:
--
To view, visit http://gerrit.ovirt.org/7336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75afb85ba154808cd3254a1310e0350e6c4279fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
