Shireesh Anjal has posted comments on this change.
Change subject: core: Performance enhancement for DAO test cases
......................................................................
Patch Set 1: (1 inline comment)
Response to Allon's comments inside. Will be sending another patch-set which
rolls back the database changes in @After method instead of @AfterClass
Mike, I haven't used TransactionalTestExecutionListener before, and don't see
it being used anywhere else in oVirt. I'm not sure about how to use it or what
value it adds. So my next patch-set doesn't make use of the spring transaction
mechanisms. If you still insist on it, I'll take some time to find out about it
and use the same. Any pointers in this regard will be highly appreciated :)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 122: if(dataSource != null) {
Line 123: Connection con = dataSource.getConnection();
Line 124: if(con != null) {
Line 125: // rollback any changes done to DB during the test
case execution
Line 126: con.rollback();
I'm changing the code to do rollback at each test case level (@After) in a new
tearDown() method.
I don't think we should preserve the current behavior of tearDownTestCase() as
it will mean that the datasource will be destroyed after every test case (class
level), and hence will have to be initialized for every test case class.
Line 127: }
Line 128: }
Line 129: }
Line 130:
--
To view, visit http://gerrit.ovirt.org/7336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75afb85ba154808cd3254a1310e0350e6c4279fa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
