Liran Zelkha has posted comments on this change. Change subject: engine: DB persistent quartz scheduler ......................................................................
Patch Set 4: (2 comments) Why do we need to have both memory and DB? If we have DB - why not just move everything to the DB? http://gerrit.ovirt.org/#/c/36297/4/packaging/services/ovirt-engine/ovirt-engine.xml.in File packaging/services/ovirt-engine/ovirt-engine.xml.in: Line 162: <check-valid-connection-sql>select 1</check-valid-connection-sql> Line 163: </validation> Line 164: </datasource> Line 165: Line 166: <datasource jndi-name="java:/ENGINEDataSourceNoJTA" pool-name="ENGINEDataSourceNoTx" enabled="true" use-ccm="false" jta="false"> Why do we want a non-JTA data source? This could lead to troubles... Line 167: <connection-url><![CDATA[$getstring('ENGINE_DB_URL')]]></connection-url> Line 168: <driver>postgresql</driver> Line 169: <transaction-isolation>TRANSACTION_READ_COMMITTED</transaction-isolation> Line 170: <pool> Line 168: <driver>postgresql</driver> Line 169: <transaction-isolation>TRANSACTION_READ_COMMITTED</transaction-isolation> Line 170: <pool> Line 171: <min-pool-size>$getinteger('ENGINE_DB_MIN_CONNECTIONS')</min-pool-size> Line 172: <max-pool-size>$getinteger('ENGINE_DB_MAX_CONNECTIONS')</max-pool-size> > I could use different configuration values here Please do - these are very high numbers in performance environments Line 173: <prefill>true</prefill> Line 174: </pool> Line 175: <security> Line 176: <user-name><![CDATA[$getstring('ENGINE_DB_USER')]]></user-name> -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
