Moti Asayag has posted comments on this change. Change subject: engine: DB persistent quartz scheduler ......................................................................
Patch Set 3: (4 comments) I haven't conducted in-depth review, but here are couple of thoughts: 1. We double the number of connections to the db 2. We add up to 100 threads for the scheduler I'm not a performance expert, but those should be considered (adding Liran for his input) How would you manage the jobs ? By plain insert/update/delete sql statements ? How would you support configuration variable (i.e. as rate/delay) for these jobs ? Thanks, Moti http://gerrit.ovirt.org/#/c/36297/3/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzDBImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzDBImpl.java: please use formatter to format the class Line 1: package org.ovirt.engine.core.utils.timer; Line 2: Line 3: import java.io.IOException; Line 4: import java.util.Date; Line 22: import org.quartz.impl.StdSchedulerFactory; Line 23: import org.slf4j.Logger; Line 24: import org.slf4j.LoggerFactory; Line 25: Line 26: // Here we use a Singleton bean, names Scheduler. s/Scheduler/SchedulerDB Line 27: // The @Startup annotation is to make sure the bean is initialized on startup. Line 28: // @ConcurrencyManagement - we use bean managed concurrency: Line 29: // Singletons that use bean-managed concurrency allow full concurrent access to all the Line 30: // business and timeout methods in the singleton. Line 35: @TransactionAttribute(TransactionAttributeType.NOT_SUPPORTED) Line 36: @ConcurrencyManagement(ConcurrencyManagementType.BEAN) Line 37: public class SchedulerUtilQuartzDBImpl extends SchedulerUtilQuartzImpl implements SchedulerUtil { Line 38: Line 39: // members the comment is redundant Line 40: private final Logger log = LoggerFactory.getLogger(SchedulerUtilQuartzDBImpl.class); Line 41: Line 42: /* Line 43: * retrieving the quartz scheduler from the factory. http://gerrit.ovirt.org/#/c/36297/3/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java: Line 5: */ Line 6: public enum BeanType { Line 7: BACKEND, // Backend bean Line 8: SCHEDULER, // SchedulerUtil Line 9: SCHEDULERDB, // SchedulerUtil perhaps PERSISTENT_SCHEDULER ? Line 10: VDS_EVENT_LISTENER, Line 11: LOCK_MANAGER, Line 12: EVENTQUEUE_MANAGER, Line 13: CACHE_CONTAINER; -- To view, visit http://gerrit.ovirt.org/36297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
