Amit Aviram has posted comments on this change. Change subject: core: StorageHandlingCommandBase, Config values cleanup. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36318/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java: Line 220: public void canDoActionFailsUnsupportedExportFormat() { Line 221: sd.setStorageDomainType(StorageDomainType.ImportExport); Line 222: CanDoActionTestUtils.runAndAssertCanDoActionFailure Line 223: (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); Line 224: } > same question All checked, they all failed by the validator. Line 225: Line 226: @Test Line 227: public void canDoActionFailsNoConnection() { Line 228: when(sscDao.get(connId.toString())).thenReturn(null); -- To view, visit http://gerrit.ovirt.org/36318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
