Allon Mureinik has posted comments on this change. Change subject: core: StorageHandlingCommandBase, Config values cleanup. ......................................................................
Patch Set 1: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/36318/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java: Line 199: public void canDoActionFailsUnsupportedFormat() { Line 200: sp.setcompatibility_version(Version.v3_0); Line 201: CanDoActionTestUtils.runAndAssertCanDoActionFailure Line 202: (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL); Line 203: } So now this test actually tests the internal validator? Line 204: Line 205: @Test Line 206: public void canDoActionFailsUnsupportedBlockOnlyFormat() { Line 207: sd.setStorageFormat(StorageFormatType.V2); Line 206: public void canDoActionFailsUnsupportedBlockOnlyFormat() { Line 207: sd.setStorageFormat(StorageFormatType.V2); Line 208: CanDoActionTestUtils.runAndAssertCanDoActionFailure Line 209: (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); Line 210: } same question Line 211: Line 212: @Test Line 213: public void canDoActionFailsUnsupportedIsoFormat() { Line 214: sd.setStorageDomainType(StorageDomainType.ISO); Line 213: public void canDoActionFailsUnsupportedIsoFormat() { Line 214: sd.setStorageDomainType(StorageDomainType.ISO); Line 215: CanDoActionTestUtils.runAndAssertCanDoActionFailure Line 216: (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); Line 217: } same question Line 218: Line 219: @Test Line 220: public void canDoActionFailsUnsupportedExportFormat() { Line 221: sd.setStorageDomainType(StorageDomainType.ImportExport); Line 220: public void canDoActionFailsUnsupportedExportFormat() { Line 221: sd.setStorageDomainType(StorageDomainType.ImportExport); Line 222: CanDoActionTestUtils.runAndAssertCanDoActionFailure Line 223: (cmd, VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST); Line 224: } same question Line 225: Line 226: @Test Line 227: public void canDoActionFailsNoConnection() { Line 228: when(sscDao.get(connId.toString())).thenReturn(null); http://gerrit.ovirt.org/#/c/36318/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java: Line 52: List<StoragePoolIsoMap> isoMap = new ArrayList<>(); Line 53: Line 54: @ClassRule Line 55: public static MockConfigRule mcr = new MockConfigRule( Line 56: // Indicates a supported storage format of V2 & V3 in version 3.4 You remove the code this comment refers too - please remove it too please. Line 57: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_0.toString(), false), Line 58: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_4.toString(), true), Line 59: mockConfig(ConfigValues.GlusterFsStorageEnabled, Version.v3_5.toString(), true), Line 60: mockConfig(ConfigValues.PosixStorageEnabled, Version.v3_0.toString(), false), -- To view, visit http://gerrit.ovirt.org/36318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
