Allon Mureinik has posted comments on this change. Change subject: core: StorageHandlingCommandBase, Config values cleanup. ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36318/4/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 832: ------------------------------------------------------------------------------------ Line 833: -- Cleanup deprecated configuration values section Line 834: ------------------------------------------------------------------------------------ Line 835: Line 836: select fn_db_delete_config_value('SupportedStorageFormats','general'); This isn't a general conf value. You should have select fn_db_delete_config_value('SupportedStorageFormats','3.1,3.2,3.3,3.4,3.5'); Line 837: select fn_db_delete_config_value('AsyncPollingCyclesBeforeCallbackCleanup','general'); Line 838: select fn_db_delete_config_value('AsyncPollingCyclesBeforeRefreshSuspend','general'); Line 839: select fn_db_delete_config_value('AutoMode','general'); Line 840: select fn_db_delete_config_value('AutoSuspendTimeInMinutes','general'); -- To view, visit http://gerrit.ovirt.org/36318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
