Eli Mesika has posted comments on this change.

Change subject: core: StorageHandlingCommandBase, Config values cleanup.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36318/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql:

please add a cal to fn_db_delete_config_value in order to clean DB (look for 
the DELETE section in this file ...)
Line 1: 
/************************************************************************************
Line 2:                 DATABASE APPLICATION CONFIGURATION FILE
Line 3: 
Line 4: This file is used to update the vdc_options configuration table.


-- 
To view, visit http://gerrit.ovirt.org/36318
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0c9bdc034fd09054ab11137bbc372514d3e74bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to