Ravi Nori has posted comments on this change. Change subject: core : Add engine sso ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/36119/12/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSORedirectServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSORedirectServlet.java: Line 36: */ Line 37: private void handleAuthenticatedUser(HttpSession session, HttpServletRequest request, HttpServletResponse response) Line 38: throws ServletException, IOException { Line 39: String module = request.getParameter(SSOUtils.MODULE); Line 40: if (StringUtils.isNotEmpty(module)) { > if there is no module this should be an error, no reason to handle it "nice What happens if user directly accesses /ovirt-engine/sso ? Line 41: try { Line 42: SSOUtils.redirectToModule( Line 43: (SSOUserGroupManager) getServletContext().getAttribute(SSOUtils.USER_GROUP_MANAGER), Line 44: (ExtMap) session.getAttribute(SSOUtils.SSO_PRINCIPAL_RECORD_ATTR_NAME), http://gerrit.ovirt.org/#/c/36119/12/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOExtensionsManager.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOExtensionsManager.java: Line 21: private static Logger log = LoggerFactory.getLogger(SSOExtensionsManager.class); Line 22: Line 23: public SSOExtensionsManager() { Line 24: super(); Line 25: getGlobalContext().put( > where does this getGlobalContext() comes from? It is declared and intialized in ExtensionsManager private ExtMap globalContext = new ExtMap().mput(Base.GlobalContextKeys.EXTENSIONS, new ArrayList<ExtMap>()); Line 26: Base.GlobalContextKeys.APPLICATION_NAME, Line 27: Base.ApplicationNames.OVIRT_ENGINE); Line 28: } Line 29: -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
