Ravi Nori has posted comments on this change. Change subject: core : Add engine sso ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/36119/11/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/EngineSSOServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/EngineSSOServlet.java: Line 35: response.setContentType("text/html;charset=UTF-8"); Line 36: dispatcher.forward(request, response); Line 37: } else { Line 38: handleUnauthenticatedUser(session, request, response); Line 39: } > I asked in the past, it is not clear to me what is the difference between t I will rename the method to authenticateUser to make it more clear Line 40: } Line 41: Line 42: private boolean containsUserCredentials(Map<String, String[]> parameters) { Line 43: return parameters.containsKey(USERNAME) && parameters.containsKey(PASSWORD) && parameters.containsKey(DOMAIN); http://gerrit.ovirt.org/#/c/36119/11/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSORedirectServlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSORedirectServlet.java: Line 50: } catch (SQLException ex) { Line 51: throw new RuntimeException(ex); Line 52: } Line 53: } else { Line 54: RequestDispatcher dispatcher = request.getRequestDispatcher("/WEB-INF/ovirt.jsp"); > in which case can we reach here without module? maybe better to just return When you access /ovirt-engine/sso directly we have no module in request parameters Line 55: response.setContentType("text/html;charset=UTF-8"); Line 56: dispatcher.forward(request, response); Line 57: } Line 58: } -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
