Alon Bar-Lev has posted comments on this change.

Change subject: core : Add engine sso
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/36119/11/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSORedirectServlet.java
File 
backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/SSORedirectServlet.java:

Line 50:             } catch (SQLException ex) {
Line 51:                 throw new RuntimeException(ex);
Line 52:             }
Line 53:         } else {
Line 54:             RequestDispatcher dispatcher = 
request.getRequestDispatcher("/WEB-INF/ovirt.jsp");
> When you access /ovirt-engine/sso directly we have no module in request par
but nobody should access that... either default or login or ovirt.jsp...
Line 55:             response.setContentType("text/html;charset=UTF-8");
Line 56:             dispatcher.forward(request, response);
Line 57:         }
Line 58:     }


-- 
To view, visit http://gerrit.ovirt.org/36119
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to