Moti Asayag has posted comments on this change. Change subject: engine: Prevents duplicates parameters in multiple actions ......................................................................
Patch Set 1: (4 comments) commenting to missed comments - patch will follow http://gerrit.ovirt.org/#/c/36102/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java: Line 37: public MultipleActionsRunner(VdcActionType actionType, List<VdcActionParametersBase> parameters, CommandContext commandContext, boolean isInternal) { Line 38: this.actionType = actionType; Line 39: this.isInternal = isInternal; Line 40: this.commandContext = commandContext; Line 41: this.parameters = new LinkedHashSet<>(parameters); > I wonder, why LinkedHashSet ? The previous type was list, which is an ordered collection. In order to preserve (as much as can) the original order, decided to go with LinkedHashSet implementation. Line 42: } Line 43: Line 44: protected Set<VdcActionParametersBase> getParameters() { Line 45: return parameters; http://gerrit.ovirt.org/#/c/36102/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java: Line 62: return getFirstParam() != null ? getFirstParam().getVmPoolId() : null; Line 63: } Line 64: Line 65: private RemoveVmFromPoolParameters getFirstParam() { Line 66: Iterator<VdcActionParametersBase> iterator = getParameters() == null ? null : getParameters().iterator(); > since we don't really need the VdcActionParametersBase type I would change Done Line 67: if (iterator != null && iterator.hasNext()) { Line 68: VdcActionParametersBase param = iterator.next(); Line 69: if (param instanceof RemoveVmFromPoolParameters) { Line 70: return ((RemoveVmFromPoolParameters) param); http://gerrit.ovirt.org/#/c/36102/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java: Line 26: } Line 27: Line 28: @Override Line 29: public ArrayList<VdcReturnValueBase> execute() { Line 30: Iterator<VdcActionParametersBase> iterator = getParameters() == null ? null : getParameters().iterator(); > same here Done Line 31: if (iterator != null && iterator.hasNext()) { Line 32: VdcActionParametersBase parameter = iterator.next(); Line 33: StoragePool pool = DbFacade.getInstance().getStoragePoolDao().get( Line 34: ((StorageDomainPoolParametersBase) parameter).getStoragePoolId()); Line 37: for (VdcActionParametersBase param : getParameters()) { Line 38: storageDomainIds.add(((StorageDomainPoolParametersBase) param).getStorageDomainId()); Line 39: } Line 40: ArrayList<VdcActionParametersBase> parameters = new ArrayList<VdcActionParametersBase>(); Line 41: parameters.add(new StoragePoolWithStoragesParameter(pool, storageDomainIds, parameter.getSessionId())); > some unrelated noise? no...just reusing the first parameter from the iterator instead of re-creating an iterator and fetching it. Line 42: if (isInternal) { Line 43: return Backend.getInstance().runInternalMultipleActions(VdcActionType.AddStoragePoolWithStorages, Line 44: parameters); Line 45: } else { -- To view, visit http://gerrit.ovirt.org/36102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
