Arik Hadas has submitted this change and it was merged. Change subject: engine: Prevents duplicates parameters in multiple actions ......................................................................
engine: Prevents duplicates parameters in multiple actions The multiple action runner api serves as a method for invoking multiple actions in a single call to the engine. However, it turns out that due to a mysterious bug, in few flows the UI provides the same parameter more than once which might lead to an unexpected behavior (i.e. infinite locked vm). By replacing the parameters collection type to set we prevent that from happen, and each parameter class will implement its own euqals() and hasCode() methods to enforce the uniqueness. Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Signed-off-by: Moti Asayag <masa...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java 3 files changed, 20 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/36102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
