Moti Asayag has posted comments on this change. Change subject: engine: Prevents duplicates parameters in multiple actions ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/36102/1//COMMIT_MSG Commit Message: Line 11: However, it turns out that due to a mysterious bug, in few Line 12: flows the UI provides the same paramter more than once which Line 13: might lead to unexpected behavior (i.e. infinite locked vm). Line 14: Line 15: By replacing the parameters collection type to list we prevents > replacing to set? Done Line 16: that from happen, and each parameter class will implement its Line 17: own euqals() and hasCode() method to enforce the uniqueness. Line 18: Line 19: Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Line 12: flows the UI provides the same paramter more than once which Line 13: might lead to unexpected behavior (i.e. infinite locked vm). Line 14: Line 15: By replacing the parameters collection type to list we prevents Line 16: that from happen, and each parameter class will implement its > we prevent that from happening. Done Line 17: own euqals() and hasCode() method to enforce the uniqueness. Line 18: Line 19: Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Line 13: might lead to unexpected behavior (i.e. infinite locked vm). Line 14: Line 15: By replacing the parameters collection type to list we prevents Line 16: that from happen, and each parameter class will implement its Line 17: own euqals() and hasCode() method to enforce the uniqueness. > methods Done Line 18: Line 19: Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Line 16: that from happen, and each parameter class will implement its Line 17: own euqals() and hasCode() method to enforce the uniqueness. Line 18: Line 19: Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Line 20: Signed-off-by: Moti Asayag <masa...@redhat.com> > missing Bug-Url Done -- To view, visit http://gerrit.ovirt.org/36102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
