Sharad Mishra has uploaded a new change for review. Change subject: core: Remove deprecated StringHelper in AddExistingSANStorageDomainCommand. ......................................................................
core: Remove deprecated StringHelper in AddExistingSANStorageDomainCommand. Replaced StringHelper with StringUtils Change-Id: I687dacfb991c59cc5330eea50082c18dd54c96bd Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/7239/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java index 1fe9353..ec546dc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingSANStorageDomainCommand.java @@ -1,10 +1,10 @@ package org.ovirt.engine.core.bll.storage; +import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.common.action.AddSANStorageDomainParameters; import org.ovirt.engine.core.common.businessentities.SANState; import org.ovirt.engine.core.common.businessentities.storage_domain_static; import org.ovirt.engine.core.compat.Guid; -import org.ovirt.engine.core.compat.StringHelper; import org.ovirt.engine.core.dal.VdcBllMessages; import org.ovirt.engine.core.utils.Pair; @@ -40,10 +40,10 @@ @Override protected boolean ConcreteCheckExistingStorageDomain(Pair<storage_domain_static, SANState> domainFromIrs) { boolean returnValue = false; - if (!StringHelper.isNullOrEmpty(getStorageDomain().getStorageStaticData().getstorage()) - && !StringHelper.isNullOrEmpty(domainFromIrs.getFirst().getstorage())) { + if (!StringUtils.isEmpty(getStorageDomain().getStorageStaticData().getstorage()) + && !StringUtils.isEmpty(domainFromIrs.getFirst().getstorage())) { returnValue = - (StringHelper.EqOp(domainFromIrs.getFirst().getstorage(), getStorageDomain().getStorageStaticData() + (StringUtils.equals(domainFromIrs.getFirst().getstorage(), getStorageDomain().getStorageStaticData() .getstorage())); } if (!returnValue) { -- To view, visit http://gerrit.ovirt.org/7239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I687dacfb991c59cc5330eea50082c18dd54c96bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches